Improve get_asset_relative_path(...) #108

strarsis · 2017-03-24T19:18:09Z

This PR improves the get_asset_relative_path(...) by using WordPress constants, variables and functions to make it compatible with different types of WordPress configurations and setups (notably WordPress Bedrock).

kasparsd

@strarsis Please see my comments on this one.

Secondly, what is the value of $this->handler->base_url for those scripts that were failing in your case? Can you please mention some examples?

kasparsd · 2017-03-24T19:28:14Z

include/minit-assets.php

@@ -230,21 +230,17 @@ protected function get_asset_relative_path( $handle ) {
 			return false;
 		}

-		// Remove protocol reference from the local base URL
-		$base_url = preg_replace( '/^(https?:)/i', '', $this->handler->base_url );
+   		 $arr = explode(plugins_url(), $item_url);


@strarsis What about plugins and WP core files? plugins_url() works only with assets in plugins.

kasparsd · 2017-03-24T19:28:59Z

include/minit-assets.php

 			return false;
 		}

-		// Get the trailing part of the local URL
-		$maybe_relative = array_pop( $src_parts );
+    		$path_abs = WP_PLUGIN_DIR . $url_rel;


Same here, WP_PLUGIN_DIR is plugin only.

strarsis · 2017-03-24T19:43:25Z

$this->handler->base_url is always http://<hostname>/wp,
plugin files are in http://<hostname>/app/plugins,
theme files are in http://<hostname>/app/themes.

@kasparsd: I modified the function to handle also theme specific URLs.
The function currently doesn't return a relative path but an absolute path, but after adjusting the other code to expect an absolute function it actually works now in my WordPress Bedrock setup.
Edit: Now I understand why a relative path is expected, the URLs in the CSS files are adjusted, too.

strarsis · 2017-03-24T20:04:05Z

$this->handler->base_url is http://<hostname>/wp - but the themes are http://<hostname>/app/themes - the URLs in these CSS files don't work because they assume a '/wp' prefix.

@kasparsd:
resolve_urls(...) and resolve_imports(...) have to differentiate between plugins and theme URLs.
For each URL, also the type has to be stored so minit later knows what kind of resource it is.

Update minit-assets.php

e515926

strarsis mentioned this pull request Mar 24, 2017

Support different plugin/theme paths than default ones #107

Open

kasparsd requested changes Mar 24, 2017

View reviewed changes

Update minit-assets.php

ff31d82

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve get_asset_relative_path(...) #108

Improve get_asset_relative_path(...) #108

strarsis commented Mar 24, 2017

kasparsd left a comment

kasparsd Mar 24, 2017

kasparsd Mar 24, 2017

strarsis commented Mar 24, 2017 •

edited

Loading

strarsis commented Mar 24, 2017 •

edited

Loading

Improve get_asset_relative_path(...) #108

Are you sure you want to change the base?

Improve get_asset_relative_path(...) #108

Conversation

strarsis commented Mar 24, 2017

kasparsd left a comment

Choose a reason for hiding this comment

kasparsd Mar 24, 2017

Choose a reason for hiding this comment

kasparsd Mar 24, 2017

Choose a reason for hiding this comment

strarsis commented Mar 24, 2017 • edited Loading

strarsis commented Mar 24, 2017 • edited Loading

strarsis commented Mar 24, 2017 •

edited

Loading

strarsis commented Mar 24, 2017 •

edited

Loading